Re: git /objects directory created 755 by default?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 22, 2005, 15:09 UTC
Message-ID: <Pine.LNX.4.63.0512221603490.18668@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <81b0412b0512220638j382252b5l24e1c6b261165bd6@mail.gmail.com>

Hi,

On Thu, 22 Dec 2005, Alex Riesen wrote:

Show 8 quoted lines

> On 12/22/05, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> >
> > What would shell.umask do? Be set only when git-shell is called? Then you
> > better have the policy to access that particular repository *only* via
> > git-shell. Voila, it is the same effect as of core.umask.
> 
> I mean it to be set only when git-shell called, but with explicit semantics
> ("for git-shell only").

But if somebody writes to the same repository with another umask, say 0022, you have problems. Example:

- I push -- via ssh/bash -- to the repository. The ref refs/heads/bruchpilot
  is updated (mode: 0644).

- My colleague pushes -- via ssh/git-shell -- to the repository. When she
  tries to write refs/heads/bruchpilot, it fails, even if she set the 
  correct umask.

See what I mean? It makes no sense to allow different umasks on the repository.

Show 5 quoted lines

> > What would shared.umask do? Be set only when writing to GIT_DIR? This is a
> > major task, since you have to find out which writes are to the working
> > directory, which ones go to GIT_DIR.
> 
> shared.mask = shell.mask. Just a name to express what it is for

You do mean different umasks for different access methods, don't you? See above why I don't think that makes sense.

Ciao, Dscho