Re: git /objects directory created 755 by default?

From: Junio C Hamano <junkio@cox.net>
Date: Dec 21, 2005, 05:03 UTC
Message-ID: <7vacevdoti.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <46a038f90512201828w618a64dexc22a64b8b6bc2b70@mail.gmail.com>

Martin Langhoff <martin.langhoff@gmail.com> writes:

>> If so, do your developers use git-shell?
>
> no...

While we established that your problem did not have anything to do with git-shell, I am tempted to do something like this.

Thoughts?

-- >8 -- [PATCH] Force group writable umask in git-shell

Usually I do not like hardcoded policy in programs, but use of git-shell is already a policy decision by the repository administrator to use the shared repository style of development, and I cannot think of a reason to forbid group (and self, but that is obvious) writability in such use scenario.

Signed-off-by: Junio C Hamano <junkio@cox.net>

---

diff --git a/shell.c b/shell.c
index cd31618..40a2a97 100644
--- a/shell.c
+++ b/shell.c
@@ -52,6 +52,10 @@ int main(int argc, char **argv)
 		default:
 			continue;
 		}
+		/* Make sure myself and my group members can write
+		 * into what I create.
+		 */
+		umask(umask(0) & ~0770);
 		exit(cmd->exec(cmd->name, arg));
 	}
 	die("unrecognized command '%s'", prog);