Re: [PATCH] Resurrect diff-tree-helper -R

From: Linus Torvalds <torvalds@osdl.org>
Date: May 1, 2005, 05:33 UTC
Message-ID: <Pine.LNX.4.58.0504302228230.2296@ppc970.osdl.org>
In-Reply-To: <20050501014726.GA15220@nevyn.them.org>

On Sat, 30 Apr 2005, Daniel Jacobowitz wrote:

Show 9 quoted lines

> 
> It sounds good - but could you efficiently collect them before any diff
> output?  If you have something like this, it'll be easy to read:
> 
> Mode change: 644->755 foo.sh
> Mode change: 644->755 bar.sh
> 
> --- ChangeLog
> +++ ChangeLog

That may sound like a good idea, but it's horrid.

You'd only have to gather them back later anyway, since you can only apply the mode change _after_ you've done the diff. Why? The diff may be the thing that creates the file in the first place. Sp you should consider the mode changes as part of the "stream", not as something separate from the stream.

So I'd really much rather see it more as an "Index" line, which gets prepended as part of the patch for that file (of course, either patch or modeline can be missing).

		Linus