Re: [PATCH] Resurrect diff-tree-helper -R

From: Petr Baudis <pasky@ucw.cz>
Date: May 14, 2005, 23:35 UTC
Message-ID: <20050514233538.GY3905@pasky.ji.cz>
In-Reply-To: <7vu0l5zsb4.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Sat, May 14, 2005 at 06:27:27PM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 12 quoted lines

> >>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:
> 
> Now I understand which discussion I was missing ;-).
> 
> PB> For humans I'd say "Mode change" instead of "mode" would be better, and
> PB> for machines I still think "@" would be better than "#". "#" can occur
> PB> quite naturally in some code snippets or whatever pasted to the commit
> PB> message, which is extremely unlikely for "@". What are the advantages
> PB> of "#"?
> 
> Wait a minute.  Aren't we scanning starting from the first
> '---\n'?  Why does what's in commit message matter?

Ok, that changes the whole situation. I'll take your patches as they are now in that case. :-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor