Re: [PATCH] Resurrect diff-tree-helper -R

From: Petr Baudis <pasky@ucw.cz>
Date: May 15, 2005, 09:30 UTC
Message-ID: <20050515093040.GC13024@pasky.ji.cz>
In-Reply-To: <7vr7g9uhsl.fsf@assigned-by-dhcp.cox.net>

Dear diary, on Sun, May 15, 2005 at 08:25:46AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> told me that...

Show 13 quoted lines

> >>>>> "PB" == Petr Baudis <pasky@ucw.cz> writes:
> 
> >> Wait a minute.  Aren't we scanning starting from the first
> >> '---\n'?  Why does what's in commit message matter?
> 
> PB> Ok, that changes the whole situation. I'll take your patches as they are
> PB> now in that case. :-)
> 
> Shooooooooot.  Seriously.
> 
> I already am beginning to like "\n@. " very much; it is much
> less distracting then the "# mode: " thing, especially with the
> help from additional newline.

I'd argue that it is too little distracting this way. But what I dislike more is that the diff output is now visually inconsistent - some diffs are separated by a newline and some aren't.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor