Re: [PATCH] Resurrect diff-tree-helper -R
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 1, 2005, 06:22 UTC
- Message-ID
- <7vr7grzcqu.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.58.0504302224510.2296@ppc970.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
LT> I actually do end up looking at diffs, and I'd hate it. I'd much rather LT> have as little extra fluff as possible, and putting shell scipt fragments LT> in it definitely counts as distraction.
Well I was half joking when I suggested that and I am glad to see that you have a good aesthetics ;-). How about:
- Stop attempting to be compatible with cg-patch, and drop (mode:XXXXXX) bits from the diff.
- Do keep the /dev/null change for created and deleted case.
- No "Index:" line, no "Mode change:" line, anywhere in the output. Anything that wants the mode bits and sha1 hash can do things from GIT_EXTERNAL_DIFF mechanism. Maybe document suggested usage mechanism better.
I'll whip something up along the above lines and submit it.