Re: [0/5] Parsers for git objects, porting some programs

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Apr 19, 2005, 02:04 UTC
Message-ID: <Pine.LNX.4.21.0504182201190.30848-100000@iabervon.org>
In-Reply-To: <7v7jizsh1f.fsf@assigned-by-dhcp.cox.net>

On Mon, 18 Apr 2005, Junio C Hamano wrote:

Show 19 quoted lines

> >>>>> "DB" == Daniel Barkalow <barkalow@iabervon.org> writes:
> 
> DB> On Mon, 18 Apr 2005, Linus Torvalds wrote:
> >> On Sun, 17 Apr 2005, Daniel Barkalow wrote:
> >> >
> >> > This series introduces common parsers for objects, and ports the programs
> >> > that currently use revision.h to them.
> >> > 
> >> >  1: the header files
> >> >  2: the implementations
> >> >  3: port rev-tree
> >> >  4: port fsck-cache
> >> >  5: port merge-base
> >> 
> >> Ok, having now looked at the code, I don't have any objections at all. 
> 
> I was looking at the tree part and am thinking that it would
> make it much nicer if your tree object records path for each
> entry.

As it turns out, the code I just doesn't actually record the path; it does everything else, and it should be easy to add the path to those entries. I mainly wanted object type (i.e., do I have to recurse into the object), so I skipped that one. But it should now be clear what you need to add.

	-Daniel
*This .sig left intentionally blank*