Re: [0/5] Parsers for git objects, porting some programs

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Apr 18, 2005, 20:12 UTC
Message-ID: <Pine.LNX.4.21.0504181558180.30848-100000@iabervon.org>
In-Reply-To: <Pine.LNX.4.58.0504181126480.15725@ppc970.osdl.org>

On Mon, 18 Apr 2005, Linus Torvalds wrote:

Show 14 quoted lines

> On Sun, 17 Apr 2005, Daniel Barkalow wrote:
> >
> > This series introduces common parsers for objects, and ports the programs
> > that currently use revision.h to them.
> > 
> >  1: the header files
> >  2: the implementations
> >  3: port rev-tree
> >  4: port fsck-cache
> >  5: port merge-base
> 
> Ok, having now looked at the code, I don't have any objections at all. 
> Could you clarify the "fsck" issue about reading the same object twice? 
> When does that happen?

Currently, the fsck-cache code is unpacking the objects to find out what type they are, and the old code would pass the unpacked objects to the parsing code. The new code doesn't take the unpacked objects, so it unpacks them again. (I.e., fsck-cache will look at each object exactly twice). The right solution is to have the internals reorganized slightly such that a "parse_object" method, which does what fsck-cache wants (i.e., parse this object regardless of what type it is, and tell me the type), could be fit in efficiently. But it doesn't affect the header file interface, and it's only relevant to fsck-cache, which wants to look at random junk that it doesn't have a reference to.

	-Daniel
*This .sig left intentionally blank*