git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [0/5] Parsers for git objects, porting some programs

From
Junio C Hamano <junkio@cox.net>
Date
Apr 19, 2005, 01:15 UTC
Message-ID
<7v7jizsh1f.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.21.0504181558180.30848-100000@iabervon.org>
>>>>> "DB" == Daniel Barkalow <barkalow@iabervon.org> writes:
DB> On Mon, 18 Apr 2005, Linus Torvalds wrote:
Show 12 quoted lines
>> On Sun, 17 Apr 2005, Daniel Barkalow wrote:
>> >
>> > This series introduces common parsers for objects, and ports the programs
>> > that currently use revision.h to them.
>> > 
>> >  1: the header files
>> >  2: the implementations
>> >  3: port rev-tree
>> >  4: port fsck-cache
>> >  5: port merge-base
>> 
>> Ok, having now looked at the code, I don't have any objections at all.

I was looking at the tree part and am thinking that it would make it much nicer if your tree object records path for each entry. Currently it just borrows from object.refs to represent its children, which is good enough for the applications listed above (none of them would care where in the tree the object belongs to), but I was thinking about an incremental dumper I talked about in another thread and noticed that I cannot use the current struct tree as is to compare two trees to find related sha1 files (then I would inflate both, run diff and record the output as a recipe to create one sha1 object from the other).

Or am I misreading the code that parses tree objects?
Previous: Daniel BarkalowNext: Daniel Barkalow
Message 12 of 16 in “[RFC] General object parsing”
  1. Daniel BarkalowApr 18, 2005
  2. Linus TorvaldsApr 18, 2005
  3. Daniel BarkalowApr 18, 2005
  4. 0/5 Parsers for git objects, porting some programsDaniel Barkalow, Apr 18, 2005
  5. 1/5 Header files for object parsingDaniel Barkalow, Apr 18, 2005
  6. 2/5 Implementations of parsing functionsDaniel Barkalow, Apr 18, 2005
  7. 3/5 Port rev-tree to parsing functionsDaniel Barkalow, Apr 18, 2005
  8. 4/5 Port fsck-cache to use parsing functionsDaniel Barkalow, Apr 18, 2005
  9. 5/5 Switch implementations of merge-base, port to parsingDaniel Barkalow, Apr 18, 2005
  10. Linus TorvaldsApr 18, 2005
  11. Daniel BarkalowApr 18, 2005
  12. Junio C HamanoApr 19, 2005
  13. Daniel BarkalowApr 19, 2005
  14. Daniel BarkalowApr 19, 2005
  15. Daniel BarkalowApr 18, 2005
  16. David WoodhouseApr 18, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.