RE: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl
On Friday, June 21, 2024 3:20 PM, Junio C Hamano wrote:
Show 25 quoted lines
>To: rsbecker@nexbridge.com
>Cc: 'Randall S. Becker' <the.n.e.key@gmail.com>; git@vger.kernel.org; Randall
>Becker <randall.becker@nexbridge.ca>
>Subject: Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl
>
>Junio C Hamano <gitster@pobox.com> writes:
>
>> At least for build on platforms without libcURL, you build with
>> NO_CURL defined, i.e. "make NO_CURL=NoThanks", and anything that
>> includes <curl/curl.h> is *NOT* compiled at all, avoiding the broken
>> build.
>
>Unfortunately, we cannot use the same trick, i.e. "Makefile knows not to even
>compile when NO_CURL is set", as this change is to help.c and we cannot say "if you
>do not have libcURL, you do not get any help" ;-)
>
> #ifndef NO_CURL
> #include "git-curl-compat.h"
> #endif
>
>may be a simplest workaround, as Makefile does this:
>
> ifdef NO_CURL
> BASIC_CFLAGS += -DNO_CURL
> ...