git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl

From
Randall Becker <randall.becker@nexbridge.ca>
Date
Jun 21, 2024, 19:32 UTC
Message-ID
<DS0PR17MB60315038F42A05C84A56302EF4C92@DS0PR17MB6031.namprd17.prod.outlook.com>
In-Reply-To
<xmqqplsaje6z.fsf@gitster.g>
On Friday, June 21, 2024 3:20 PM, Junio C Hamano wrote:
Show 25 quoted lines
>To: rsbecker@nexbridge.com
>Cc: 'Randall S. Becker' <the.n.e.key@gmail.com>; git@vger.kernel.org; Randall
>Becker <randall.becker@nexbridge.ca>
>Subject: Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl
>
>Junio C Hamano <gitster@pobox.com> writes:
>
>> At least for build on platforms without libcURL, you build with
>> NO_CURL defined, i.e. "make NO_CURL=NoThanks", and anything that
>> includes <curl/curl.h> is *NOT* compiled at all, avoiding the broken
>> build.
>
>Unfortunately, we cannot use the same trick, i.e. "Makefile knows not to even
>compile when NO_CURL is set", as this change is to help.c and we cannot say "if you
>do not have libcURL, you do not get any help" ;-)
>
>        #ifndef NO_CURL
>        #include "git-curl-compat.h"
>        #endif
>
>may be a simplest workaround, as Makefile does this:
>
>        ifdef NO_CURL
>                BASIC_CFLAGS += -DNO_CURL
>		...
That makes sense
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 15 in “Teach git version --build-options about zlib+libcurl”
  1. 0/1 Teach git version --build-options about zlib+libcurlRandall S. Becker, Jun 21, 2024
  2. 1/1 Teach git version --build-options about zlib+libcurlRandall S. Becker, Jun 21, 2024
  3. Junio C HamanoJun 21, 2024
  4. Junio C HamanoJun 21, 2024
  5. rsbecker@nexbridge.comJun 21, 2024
  6. Junio C HamanoJun 21, 2024
  7. Junio C HamanoJun 21, 2024
  8. Randall BeckerJun 21, 2024
  9. Junio C HamanoJun 22, 2024
  10. rsbecker@nexbridge.comJun 25, 2024
  11. Junio C HamanoJun 25, 2024
  12. rsbecker@nexbridge.comJun 25, 2024
  13. Jeff KingJun 26, 2024
  14. Junio C HamanoJun 26, 2024
  15. Jeff KingJun 26, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.