Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl

From: Jeff King <peff@peff.net>
Date: Jun 26, 2024, 20:46 UTC
Message-ID: <20240626204613.GE441931@coredump.intra.peff.net>
In-Reply-To: <03ef01dac735$f3496ac0$d9dc4040$@nexbridge.com>

On Tue, Jun 25, 2024 at 03:29:03PM -0400, rsbecker@nexbridge.com wrote:

Show 5 quoted lines

> My take on the separate patches and discussion about reporting run-time
> values of libcurl, zlib, and OpenSSL, is that these are being added to
> --build-options not --runtime-options (does not exist yet). I think that
> grabbing run-time values could be confusing to users who expect the
> --build-options even if comparing the two values.

I think that's a valid concern. I assumed we'd show both runtime and build-time values side by side, clearly labeled, rather than replace one with the other. I don't see much need for --runtime-options. The point of --build-options is to gather info about the binary for debugging. While technically you can swap out the dynamic library whenever you like, in practice I think it is about asking "what will happen now when I run git".

Likewise, you could answer that part with "ldd git", but this is about making it simpler to gather the information in one place.

-Peff