From: Randall Becker <randall.becker@nexbridge.ca>
Date: Fri, 21 Jun 2024 19:32:03 GMT
Subject: RE: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl
Message-ID: <DS0PR17MB60315038F42A05C84A56302EF4C92@DS0PR17MB6031.namprd17.prod.outlook.com>
In-Reply-To: <xmqqplsaje6z.fsf@gitster.g>

On Friday, June 21, 2024 3:20 PM, Junio C Hamano wrote:
>To: rsbecker@nexbridge.com
>Cc: 'Randall S. Becker' <the.n.e.key@gmail.com>; git@vger.kernel.org; Randall
>Becker <randall.becker@nexbridge.ca>
>Subject: Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl
>
>Junio C Hamano <gitster@pobox.com> writes:
>
>> At least for build on platforms without libcURL, you build with
>> NO_CURL defined, i.e. "make NO_CURL=NoThanks", and anything that
>> includes <curl/curl.h> is *NOT* compiled at all, avoiding the broken
>> build.
>
>Unfortunately, we cannot use the same trick, i.e. "Makefile knows not to even
>compile when NO_CURL is set", as this change is to help.c and we cannot say "if you
>do not have libcURL, you do not get any help" ;-)
>
>        #ifndef NO_CURL
>        #include "git-curl-compat.h"
>        #endif
>
>may be a simplest workaround, as Makefile does this:
>
>        ifdef NO_CURL
>                BASIC_CFLAGS += -DNO_CURL
>		...

That makes sense