Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl

From: Jeff King <peff@peff.net>
Date: Jun 26, 2024, 20:42 UTC
Message-ID: <20240626204232.GD441931@coredump.intra.peff.net>
In-Reply-To: <xmqqmsn87n9x.fsf@gitster.g>

On Tue, Jun 25, 2024 at 01:58:18PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> <rsbecker@nexbridge.com> writes:
> 
> > My take on the separate patches and discussion about reporting run-time
> > values of libcurl, zlib, and OpenSSL, is that these are being added to
> > --build-options not --runtime-options (does not exist yet). I think that
> > grabbing run-time values could be confusing to users who expect the
> > --build-options even if comparing the two values.
> 
> Yup.  I thought that the consensus was to leave all those extra
> complexities like runtime versions for a later and separate topic
> done after the dust from this change settles.

My only qualm is that reading curl.h at all in a program that is not going to link it feels a bit funny (it is declaring symbols that will not be available at link time). And we could fix that immediately by having "remote-https --build-options".

Adding a curl_version() check on top of that could come later, but of course it would be easy to do.

But that may just be me being overly conservative. If nobody looks at those symbols, I'm not sure what harm would come.

-Peff