Re: [PATCH] ssh signing: don't detach the filename strbuf from key_file tempfile

From: redoste <redoste@redoste.xyz>
Date: Jul 6, 2025, 17:14 UTC
Message-ID: <DB553KB95680.28G0KIGGWCW9L@redoste.xyz>
In-Reply-To: <aGnDO3HIAQgsRbnJ@fruit.crustytoothpaste.net>

On Sun Jul 6, 2025 at 02:28 CEST, brian m. carlson wrote:

> I think `find` is typically better in scripting and also in this case
> with a separate directory as the temporary directory we'll find any left
> over temporary files, not just the pattern we've fixed here.

Thanks for the feedback!

I used `ls` since it was the easiest way to have something that fails quickly if a file doesn't exists (and `test -e` doesn't support having multiple files), but I agree, using `find` this way is definitely cleaner.

> I'll send a patch to fix the policy.

Thanks!

-- 
redoste