Re: [PATCH] ssh signing: don't detach the filename strbuf from key_file tempfile

From: redoste <redoste@redoste.xyz>
Date: Jul 5, 2025, 23:04 UTC
Message-ID: <DB4HWL9M36X4.2GND0UHYOS8Q0@redoste.xyz>
In-Reply-To: <DB4HMD2HLG24.1V8Y9JDW6BACQ@redoste.xyz>

On Sun Jul 6, 2025 at 00:50 CEST, redoste wrote:

> Maybe something like this?

Sorry, it's my first time contributing via a mailing list and I stupidly copy-pasted the output of `git diff` without checking the whitespaces. Here is the proper version of the diff that can be applied:

diff --git a/t/t7528-signed-commit-ssh.sh b/t/t7528-signed-commit-ssh.sh
index 065f780636..359dc8eba8 100755
--- a/t/t7528-signed-commit-ssh.sh
+++ b/t/t7528-signed-commit-ssh.sh
@@ -85,6 +85,7 @@ test_expect_success GPGSSH 'sign commits using literal public keys with ssh-agen
 	eval $(ssh-agent) &&
 	test_when_finished "kill ${SSH_AGENT_PID}" &&
 	ssh-add "${GPGSSH_KEY_PRIMARY}" &&
+	export TMPDIR=$(pwd) &&
 	echo 1 >file && git add file &&
 	git commit -a -m rsa-inline -S"$(cat "${GPGSSH_KEY_PRIMARY}.pub")" &&
 	echo 2 >file &&
@@ -95,7 +96,8 @@ test_expect_success GPGSSH 'sign commits using literal public keys with ssh-agen
 	git commit -a -m ecdsa-inline -S"key::$(cat "${GPGSSH_KEY_ECDSA}.pub")" &&
 	echo 4 >file &&
 	test_config user.signingkey "key::$(cat "${GPGSSH_KEY_ECDSA}.pub")" &&
-	git commit -a -m ecdsa-config -S
+	git commit -a -m ecdsa-config -S &&
+	! ls .git_signing_key_tmp*
 '
 
 test_expect_success GPGSSH,GPGSSH_VERIFYTIME 'create signed commits with keys having defined lifetimes' '

-- 
redoste