Re: [PATCH v3] ssh signing: don't detach the filename strbuf from key_file tempfile

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jul 8, 2025, 13:59 UTC
Message-ID: <94caee19-b915-4678-900a-03095663e8a8@gmail.com>
In-Reply-To: <aGy_DEehFgw4A6va@pks.im>

On 08/07/2025 07:47, Patrick Steinhardt wrote:

Show 12 quoted lines

> On Mon, Jul 07, 2025 at 01:57:39PM -0700, Junio C Hamano wrote:
>> redoste <redoste@redoste.xyz> writes:
>>
>>> v2->v3:
>>>   * merge the test with the previous ssh-agent test
>>>   * export TMPDIR in a subshell to prevent the environment variable from
>>>     leaking in the next tests
>>>   * use test_must_be_empty instead of test_line_count
>>
>> These sound all good.  Will queue.
> 
> Yup, the patch looks good to me. Thanks!

Yes it does to me too, thanks

Phillip