Re: [PATCH] ssh signing: don't detach the filename strbuf from key_file tempfile

From: Jeff King <peff@peff.net>
Date: Jul 6, 2025, 03:13 UTC
Message-ID: <20250706031337.GA3041790@coredump.intra.peff.net>
In-Reply-To: <aGnDO3HIAQgsRbnJ@fruit.crustytoothpaste.net>

On Sun, Jul 06, 2025 at 12:28:43AM +0000, brian m. carlson wrote:

Show 20 quoted lines

> On 2025-07-05 at 22:50:43, redoste wrote:
> [...]
> > Since I knew that the Linux kernel changed their documentation to remove
> > the use of "real name", I thought it was more common and didn't relly
> > think about it a lot.
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330
> > 
> > I'm sorry, I should have read the git documentation more thoroughly.
> > 
> > If it's really an issue I don't mind signing off with a different and
> > more distinctive name.
> 
> No, I think this is fine.  You weren't obligated to explain that and our
> policies should gracefully handle this situation regardless, but given
> what I said before and this context, I think the name you have is fine.
> Git unfortunately has poor support for replacing names and I would't
> want you to have to put your deadname into our history for all of
> eternity.
> 
> I'll send a patch to fix the policy.

Ah, I hadn't heard about that change in the kernel. I agree that it would make sense to loosen our text to match.

Thanks (in advance) for sending that doc update, and for your earlier comments in the thread. I agreed with everything you wrote there. FWIW, my personal inclinations lean much more towards allowing privacy and anonymity, but as a reviewer for the project I wanted to make sure we were not violating our own policy in a way that would eventually bite us in a legal sense. The notion of "identifiable but pseudonymous" you brought up seems like a good middle ground (at least to my layman's ears).

And thanks redoste for your patch. ;) Sorry if bringing up the signoff issue caused any hassle (but hopefully it will lead to an improvement to our docs).

-Peff