Re: [PATCH] use child_process_init() to initialize struct child_process variables

From: Philip Oakley <philipoakley@iee.org>
Date: Nov 5, 2014, 12:44 UTC
Message-ID: <D4F1F843014841509E8BFB9ACC7CDBCC@PhilipOakley>
In-Reply-To: <xmqq389zrguw.fsf@gitster.dls.corp.google.com>

From: "Junio C Hamano" <gitster@pobox.com>
Sent: Monday, November 03, 2014 11:42 PM

Show 28 quoted lines

> Jeff King <peff@peff.net> writes:
>
>> I peeked at libgit2 and I think it does not support bundles at all 
>> yet,
>> so that is safe. Grepping for "bundle" in dulwich turns up no hits,
>> either.
>>
>> Looks like JGit does support them. I did a very brief test, and it 
>> seems
>> to silently ignore a HEAD ref that has the NUL (I guess maybe it just
>> rejects it as a malformed refname).
>>
>> We could make JGit happier either by:
>>
>>   1. Only including the symref magic in ambiguous cases, so that 
>> regular
>>      ones Just Work as usual.
>>
>>   2. Including two lines, like:
>>
>>         $sha1 HEAD\0symref=refs/heads/master
>> $sha1 HEAD
>>
>>      which JGit does the right thing with (and git.git seems to, as
>>      well).
>
> Sounds sensible, even though it looks ugly X-<.
>

I believe that the 'two HEADs' mechanism would also fall foul of the 'duplicate refs' warning (untested).

Philip