Re: [PATCH] use child_process_init() to initialize struct child_process variables
- From
mike.gorchak.qnx@gmail.com <mike.gorchak.qnx@gmail.com>
- Date
- Oct 28, 2014, 21:58 UTC
- Message-ID
- <20141028215856.6643859.60752.16778@gmail.com>
- In-Reply-To
- <54500212.7040603@web.de>
Sent from my BlackBerry 10 smartphone on the Rogers network. Original Message From: René Scharfe Sent: Tuesday, October 28, 2014 16:59 To: Git Mailing List Cc: Junio C Hamano Subject: [PATCH] use child_process_init() to initialize struct child_process variables
Call child_process_init() instead of zeroing the memory of variables of type struct child_process by hand before use because the former is both clearer and shorter.
Signed-off-by: Rene Scharfe <l.s.r@web.de> --- bundle.c | 2 +- column.c | 2 +- trailer.c | 2 +- transport-helper.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/bundle.c b/bundle.c index fa67057..c846092 100644 --- a/bundle.c +++ b/bundle.c @@ -381,7 +381,7 @@ int create_bundle(struct bundle_header *header, const char *path, write_or_die(bundle_fd, "\n", 1); /* write pack */ - memset(&rls, 0, sizeof(rls)); + child_process_init(&rls); argv_array_pushl(&rls.args, "pack-objects", "--all-progress-implied", "--stdout", "--thin", "--delta-base-offset", diff --git a/column.c b/column.c index 8082a94..786abe6 100644 --- a/column.c +++ b/column.c @@ -374,7 +374,7 @@ int run_column_filter(int colopts, const struct column_options *opts) if (fd_out != -1) return -1; - memset(&column_process, 0, sizeof(column_process)); + child_process_init(&column_process); argv = &column_process.args; argv_array_push(argv, "column"); diff --git a/trailer.c b/trailer.c index 8514566..7ff036c 100644 --- a/trailer.c +++ b/trailer.c @@ -237,7 +237,7 @@ static const char *apply_command(const char *command, const char *arg) strbuf_replace(&cmd, TRAILER_ARG_STRING, arg); argv[0] = cmd.buf; - memset(&cp, 0, sizeof(cp)); + child_process_init(&cp); cp.argv = argv; cp.env = local_repo_env; cp.no_stdin = 1; diff --git a/transport-helper.c b/transport-helper.c index 6cd9dd1..0224687 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -414,7 +414,7 @@ static int get_exporter(struct transport *transport, struct child_process *helper = get_helper(transport); int i; - memset(fastexport, 0, sizeof(*fastexport)); + child_process_init(fastexport); /* we need to duplicate helper->in because we want to use it after * fastexport is done with it. */
-- 2.1.2