Re: [PATCH] use child_process_init() to initialize struct child_process variables

From: Jeff King <peff@peff.net>
Date: Nov 10, 2014, 07:14 UTC
Message-ID: <20141110071410.GE7677@peff.net>
In-Reply-To: <545F7106.7070300@web.de>

On Sun, Nov 09, 2014 at 02:49:58PM +0100, René Scharfe wrote:

Show 12 quoted lines

> -- >8 --
> Subject: [PATCH] trailer: use CHILD_PROCESS_INIT in apply_command()
> 
> Initialize the struct child_process variable cp at declaration time.
> This is shorter, saves a function call and prevents using the variable
> before initialization by mistake.
> 
> Suggested-by: Jeff King <peff@peff.net>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
>  trailer.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, both this one and the other you just sent (to use child_process.args in more places) look good to me.

-Peff