Re: [PATCH] use child_process_init() to initialize struct child_process variables

From: Jeff King <peff@peff.net>
Date: Oct 30, 2014, 21:25 UTC
Message-ID: <20141030212551.GA26030@peff.net>
In-Reply-To: <xmqqlhnxwhw4.fsf@gitster.dls.corp.google.com>

On Thu, Oct 30, 2014 at 11:07:39AM -0700, Junio C Hamano wrote:

> -- >8 --
> Subject: [PATCH] bundle: split out a helper function to create a pack data

s/a pack data/pack data/

> The create_bundle() function, while it does one single logical thing
> and tries to do it well, that single logical thing takes a rather
> large implementation.

I had minor trouble parsing this. I think it might be more clearly said as just:

  The create_bundle() function, while it does one single logical thing,
  takes a rather large implementation to do so.

> Let's start separating what it does into smaller steps to make it
> easier what is going on.  This is a first step to separate out the

s/easier/& to see/

>  bundle.c | 64 +++++++++++++++++++++++++++++++++++++---------------------------
>  1 file changed, 37 insertions(+), 27 deletions(-)

The patch itself looked OK to me.

-Peff