RE: [PATCH] Put sha1dc on a diet

From

DSDan Shumow <danshu@microsoft.com>

Date

Mar 4, 2017, 01:07 UTC

Message-ID

<CY1PR0301MB2107112BCC2DECD215E70549C42A0@CY1PR0301MB2107.namprd03.prod.outlook.com>

In-Reply-To

<xmqq1suge1jn.fsf@gitster.mtv.corp.google.com>

From: Junio C Hamano [mailto:gitster@pobox.com] 

> As you and Marc seemed to be still working on speeding up, such a customization work to fully adjust your code to our codebase was premature, so I tentatively queued what we saw on the list as-is on our 'pu' branch so that people can have a reference point.  Which unfortunately solicited a premature reaction by Johannes.  Please do not worry too much about the comment.

> But if you are willing to help us by getting involved in the "customization" part, too, that would be a very welcome news to us.
>In that case, "welcome to the Git development community" ;-)

> So,... from my point of view, we are OK either way.  It is OK if you are a third-party upstream that is not particularly interested in Git project's specific requirement.  We surely would be happier if you and Marc, the upstream authors of the code in question, also act as participants in the Git development community.

> Either way, thanks for your great help.

You are very welcome.  Thank you for the warm welcome.  As it turns out, Marc and I are working on the simplifications / removal of c99 and performance upstream in our GitHub repo.  I am happy to help for any GitHub specific customizations that are needed as well.  But for now, lets see if we can get you everything you want upstream -- I think that's the most simple.