Re: [PATCH] Put sha1dc on a diet
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Mar 2, 2017, 06:10 UTC
- Message-ID
- <CACsJy8D3h1KAaKi_Esc98za3LqXaB=YeW0Yu+VAV9UnX5vmttg@mail.gmail.com>
- In-Reply-To
- <20170301231921.2puf7o7jkrujscwn@sigill.intra.peff.net>
On Thu, Mar 2, 2017 at 6:19 AM, Jeff King <peff@peff.net> wrote:
> You have to remember that some of the Git for Windows users are doing > horrific things like using repositories with 450MB .git/index files, and > the speed to compute the sha1 during an update is noticeable there.
We probably should separate this use case from the object hashing anyway. Here we need a better, more reliable crc32 basically, to detect bit flips. Even if we move to SHA-something, we can keep staying with SHA-1 here (and with the fastest implementation)
-- Duy