Re: [PATCH] Put sha1dc on a diet
- From
Jeff King <peff@peff.net>
- Date
- Mar 13, 2017, 19:48 UTC
- Message-ID
- <20170313194848.2z2dlgpomu6e3dkh@sigill.intra.peff.net>
- In-Reply-To
- <CY1PR0301MB2107876B6E47FBCF03AB1EA1C4250@CY1PR0301MB2107.namprd03.prod.outlook.com>
On Mon, Mar 13, 2017 at 07:42:17PM +0000, Dan Shumow wrote:
> Marc just made a commit this morning fixing problems with the merge. > Please give the latest in feature/performance a try, as that seems to > eliminate the problem.
Yeah, b17728507 makes the problem go away for me. Thanks.
FWIW, I have all sha1s on github.com running through this right now (actually, the ad744c8b7 version), and logging any false-positives on the collision detection. Nothing so far, after a few hours.
-Peff