Re: [PATCH] Put sha1dc on a diet

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Mar 1, 2017, 22:16 UTC
Message-ID: <CA+55aFys5oQ0RySQ+Xv0ZDussr-xZNh4_b3+Upx_d9VPWmpM8Q@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.20.1703012227010.3767@virtualbox>

On Wed, Mar 1, 2017 at 1:56 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

> Footnote *1*: I know, it is easy to forget that some developers cannot
> choose their tools, or even their hardware. In the past, we seemed to take
> appropriate care, though.

I don't think you need to worry about the Windows side. That can continue to do something else.

When I advocated perhaps using USE_SHA1DC by default, I definitely did not mean it in a "everywhere, regardless of issues" manner.

For example, the conmfig.mak.uname script already explicitly asks for "BLK_SHA1 = YesPlease" for Windows. Don't bother changing that, it's an explicit choice.

But the Linux rules don't actually specify which SHA1 version to use, so the main Makefile currently defaults to just using openssl.

So that's the "default" choice I think we might want to change. Not the "we're windows, and explicitly want BLK_SHA1 because of environment and build infrastructure".

             Linus