git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] userdiff: remove empty subexpression from elixir regex

From
Ed Maste <emaste@freebsd.org>
Date
Dec 13, 2019, 14:11 UTC
Message-ID
<CAPyFy2DfhVwEFen2G4oOdQS2uo_L=V5gyrpPWUB0uRxNSnWcuQ@mail.gmail.com>
In-Reply-To
<20191213174542.GB117158@coredump.intra.peff.net>
On Fri, 13 Dec 2019 at 12:45, Jeff King <peff@peff.net> wrote:
Show 7 quoted lines
>
> And that is the right thing, since these strings are the funcname and
> word_regex patterns, respectively.
>
> So I think this is the correct fix. Many of the other regexes in this
> list use "/* -- */" to seperate the two for readability. Maybe worth
> doing here, too?

Yeah, this elixir set seems to be the only one with comments on the individual subexpressions in the second set but the extra /* -- */ does make it a bit more clear. Patch v2 sent.

Previous: Jeff KingNext: Ed Maste
Message 3 of 10 in “userdiff: remove empty subexpression from elixir regex”
  1. userdiff: remove empty subexpression from elixir regexEd Maste, Dec 13, 2019
  2. Jeff KingDec 13, 2019
  3. Ed MasteDec 13, 2019
  4. userdiff: remove empty subexpression from elixir regexEd Maste, Dec 13, 2019
  5. Jeff KingDec 13, 2019
  6. Johannes SixtDec 13, 2019
  7. Ed MasteDec 13, 2019
  8. Junio C HamanoDec 13, 2019
  9. Numbers with specific base (was: [PATCH] userdiff: remove empty subexpression from elixir regex)Achim Gratz, Dec 13, 2019
  10. Junio C HamanoDec 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.