git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] userdiff: remove empty subexpression from elixir regex

From
Ed Maste <emaste@freebsd.org>
Date
Dec 13, 2019, 17:39 UTC
Message-ID
<20191213173902.71541-1-emaste@FreeBSD.org>
The regex failed to compile on FreeBSD.
Fixes: a807200f67588f6e
Signed-off-by: Ed Maste <emaste@FreeBSD.org>
---
 userdiff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/userdiff.c b/userdiff.c
index 324916f20f..165d7e8653 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -35,7 +35,7 @@ PATTERNS("dts",
 PATTERNS("elixir",
 	 "^[ \t]*((def(macro|module|impl|protocol|p)?|test)[ \t].*)$",
 	 /* Atoms, names, and module attributes */
-	 "|[@:]?[a-zA-Z0-9@_?!]+"
+	 "[@:]?[a-zA-Z0-9@_?!]+"
 	 /* Numbers with specific base */
 	 "|[-+]?0[xob][0-9a-fA-F]+"
 	 /* Numbers */
-- 
2.24.0
Next: Jeff King
Message 1 of 10 in “userdiff: remove empty subexpression from elixir regex”
  1. userdiff: remove empty subexpression from elixir regexEd Maste, Dec 13, 2019
  2. Jeff KingDec 13, 2019
  3. Ed MasteDec 13, 2019
  4. userdiff: remove empty subexpression from elixir regexEd Maste, Dec 13, 2019
  5. Jeff KingDec 13, 2019
  6. Johannes SixtDec 13, 2019
  7. Ed MasteDec 13, 2019
  8. Junio C HamanoDec 13, 2019
  9. Numbers with specific base (was: [PATCH] userdiff: remove empty subexpression from elixir regex)Achim Gratz, Dec 13, 2019
  10. Junio C HamanoDec 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.