git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Numbers with specific base

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 13, 2019, 22:00 UTC
Message-ID
<xmqqimmjhon9.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<87tv64ymam.fsf@Rainer.invalid>
Achim Gratz <Stromeko@nexgo.de> writes:
Show 16 quoted lines
> Nothing to do with the patch from Ed, but the regex following his
> correction matches a lot of things that decidedly are not "Numbers with
> specific bases" as it claims to do in the comment.
>
> Ed Maste writes:
>>  PATTERNS("elixir",
>>  	 "^[ \t]*((def(macro|module|impl|protocol|p)?|test)[ \t].*)$",
>>  	 /* Atoms, names, and module attributes */
>> -	 "|[@:]?[a-zA-Z0-9@_?!]+"
>> +	 "[@:]?[a-zA-Z0-9@_?!]+"
>>  	 /* Numbers with specific base */
>>  	 "|[-+]?0[xob][0-9a-fA-F]+"
>
> Here, things like "+0bad" would match as a base 2 number, which doesn't
> seem right.  If it's intended to match that broadly, I'd have expected a
> comment to that effect.

No need for such a comment, as it is implicit that we assume the user writes reasonable text that our patterns try to match.

Previous: Achim Gratz
Message 10 of 10 in “userdiff: remove empty subexpression from elixir regex”
  1. userdiff: remove empty subexpression from elixir regexEd Maste, Dec 13, 2019
  2. Jeff KingDec 13, 2019
  3. Ed MasteDec 13, 2019
  4. userdiff: remove empty subexpression from elixir regexEd Maste, Dec 13, 2019
  5. Jeff KingDec 13, 2019
  6. Johannes SixtDec 13, 2019
  7. Ed MasteDec 13, 2019
  8. Junio C HamanoDec 13, 2019
  9. Numbers with specific base (was: [PATCH] userdiff: remove empty subexpression from elixir regex)Achim Gratz, Dec 13, 2019
  10. Junio C HamanoDec 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.