git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t4210: skip i18n tests that don't work on FreeBSD

From
Ed Maste <emaste@freebsd.org>
Date
Nov 27, 2019, 13:07 UTC
Message-ID
<CAPyFy2AyQGhFxzd2AEGhtU5u6OHZD-mJy4duXCs5-YYVbvkYFA@mail.gmail.com>
In-Reply-To
<20191127162416.GB30581@sigill.intra.peff.net>
On Wed, 27 Nov 2019 at 11:24, Jeff King <peff@peff.net> wrote:
Show 8 quoted lines
>
> > Extend test-lib.sh to add a FREEBSD prereq (akin to MINGW) and add !FREEBSD
> > to these tests.
>
> Before we start growing more system-specific prereqs here, can we add a
> layer of indirection? Convert this test to use a REGEX_ALLOW_ILLSEQ
> prereq (or maybe there's a better name), and then set it for both mingw
> and freebsd?

Thanks, and that makes sense, but should we make the sense the opposite way - set REGEX_ALLOW_ILLSEQ only for glibc (including Cygwin, I guess)?

This also applies only to two cases ("latin1 + locale" and "latin1 + locale + invalid needle"). There are other !MINGW tests in t4210-log-i18n.sh which do not use invalid UTF-8 and work fine on FreeBSD.

Previous: Jeff KingNext: Jeff King
Message 3 of 9 in “t4210: skip i18n tests that don't work on FreeBSD”
  1. t4210: skip i18n tests that don't work on FreeBSDEd Maste, Nov 27, 2019
  2. Jeff KingNov 27, 2019
  3. Ed MasteNov 27, 2019
  4. Jeff KingNov 27, 2019
  5. t4210: skip i18n tests that don't work on FreeBSDEd Maste, Nov 27, 2019
  6. Jeff KingNov 27, 2019
  7. Ed MasteNov 27, 2019
  8. Ed MasteDec 2, 2019
  9. Junio C HamanoDec 2, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.