Re: [PATCH v2] t4210: skip i18n tests that don't work on FreeBSD

From: Ed Maste <emaste@freebsd.org>
Date: Nov 27, 2019, 13:44 UTC
Message-ID: <CAPyFy2BEADNbk8ZjWvTdVu1WtU7Gtxs1Psri1aFzYD358rDRWw@mail.gmail.com>
In-Reply-To: <20191127172035.GB1123@sigill.intra.peff.net>

On Wed, 27 Nov 2019 at 12:20, Jeff King <peff@peff.net> wrote:

Show 16 quoted lines

>
> On Wed, Nov 27, 2019 at 05:15:07PM +0000, Ed Maste wrote:
>
> > +FreeBSD)
> > +     test_set_prereq REGEX_ILLSEQ
> > +     test_set_prereq POSIXPERM
> > +     test_set_prereq BSLASHPSPEC
> > +     test_set_prereq EXECKEEPSPID
> > +     ;;
>
> I scratched my head at these for a minute, but I see you are just
> covering the bits set in the "*" case that we now no longer trigger.
>
> It would probably be cleaner to set them ahead of time and just unset
> them selectively in MINGW, etc. But we don't have any way to unset a
> prereq, so lets' go with this for now. :)

Indeed, I'm happy to help with reworking this later on - perhaps informed by finding other operating systems that need REGEX_ILLSEQ.