Re: [PATCH v2] t4210: skip i18n tests that don't work on FreeBSD

From: Jeff King <peff@peff.net>
Date: Nov 27, 2019, 17:20 UTC
Message-ID: <20191127172035.GB1123@sigill.intra.peff.net>
In-Reply-To: <20191127171507.56354-1-emaste@freefall.freebsd.org>

On Wed, Nov 27, 2019 at 05:15:07PM +0000, Ed Maste wrote:

> Extend test-lib.sh to add a REGEX_ILLSEQ prereq, set it on FreeBSD, and
> add !REGEX_ILLSEQ to the two affected tests.

Thanks, this is much nicer.

Show 6 quoted lines

> +FreeBSD)
> +	test_set_prereq REGEX_ILLSEQ
> +	test_set_prereq POSIXPERM
> +	test_set_prereq BSLASHPSPEC
> +	test_set_prereq EXECKEEPSPID
> +	;;

I scratched my head at these for a minute, but I see you are just covering the bits set in the "*" case that we now no longer trigger.

It would probably be cleaner to set them ahead of time and just unset them selectively in MINGW, etc. But we don't have any way to unset a prereq, so lets' go with this for now. :)

-Peff