From: Ed Maste <emaste@freebsd.org>
Date: Wed, 27 Nov 2019 13:07:30 GMT
Subject: Re: [PATCH] t4210: skip i18n tests that don't work on FreeBSD
Message-ID: <CAPyFy2AyQGhFxzd2AEGhtU5u6OHZD-mJy4duXCs5-YYVbvkYFA@mail.gmail.com>
In-Reply-To: <20191127162416.GB30581@sigill.intra.peff.net>

On Wed, 27 Nov 2019 at 11:24, Jeff King <peff@peff.net> wrote:
>
> > Extend test-lib.sh to add a FREEBSD prereq (akin to MINGW) and add !FREEBSD
> > to these tests.
>
> Before we start growing more system-specific prereqs here, can we add a
> layer of indirection? Convert this test to use a REGEX_ALLOW_ILLSEQ
> prereq (or maybe there's a better name), and then set it for both mingw
> and freebsd?

Thanks, and that makes sense, but should we make the sense the
opposite way - set REGEX_ALLOW_ILLSEQ only for glibc (including
Cygwin, I guess)?

This also applies only to two cases ("latin1 + locale" and "latin1 +
locale + invalid needle"). There are other !MINGW tests in
t4210-log-i18n.sh which do not use invalid UTF-8 and work fine on
FreeBSD.