Re: [PATCH 1/8] clang-format: indent preprocessor directives after hash

From: Chris Torek <chris.torek@gmail.com>
Date: Jul 8, 2024, 10:08 UTC
Message-ID: <CAPx1GvfExeYEwStqDDeyuTW02Yi_n9Php-t-T6waadTgyk-XSg@mail.gmail.com>
In-Reply-To: <20240708092317.267915-2-karthik.188@gmail.com>

On Mon, Jul 8, 2024 at 2:23 AM Karthik Nayak <karthik.188@gmail.com> wrote:

> Let's pick the former and add 'IndentPPDirectives: AfterHash' value to
> our '.clang-format'. There is no clear reason to pick one over the
> other, but it would definitely be nicer to be consistent.

There is one extremely weak technical reason to pick "# in left column", which is: some ancient C compilers required it. I don't think any modern ones do.

Chris

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.