Re: [PATCH 8/8] check-whitespace: detect if no base_commit is provided

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jul 8, 2024, 17:13 UTC
Message-ID: <CAOLa=ZQSDoKHtVRav2DpJhMgy3yhyLZ_itF2Q9fsbPy0WuTvbw@mail.gmail.com>
In-Reply-To: <CAPx1GvcunqYvZtkSJ0wDd4802VPEyRzDJnZmfoGh6L1rFof2vQ@mail.gmail.com>

Chris Torek <chris.torek@gmail.com> writes:

Show 14 quoted lines

> On Mon, Jul 8, 2024 at 3:35 AM Georg Pfuetzenreuter <georg@syscid.com> wrote:
>> https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html states
>>
>> "The XSI extensions specifying the -a and -o binary primaries and the
>> '(' and ')' operators have been marked obsolescent."
>>
>> suggesting "&&" being preferred over "-a".
>
> That's annoying, I wonder why they did that. It does make
> the "test" parser a bit tricky, especially with empty expansions,
> but empty expansions are already a problem requiring careful
> quoting in the first place...
>
> Chris

Thanks both, I think with this, it makes sense to keep it as is.