Re: [PATCH 0/8] clang-format: add more rules and enable on CI

From: Chris Torek <chris.torek@gmail.com>
Date: Jul 8, 2024, 10:06 UTC
Message-ID: <CAPx1GveNmpM=v2Kymi7euuerciZKHqPmmexqPdMxKUEA7oAEkQ@mail.gmail.com>
In-Reply-To: <20240708092317.267915-1-karthik.188@gmail.com>

On Mon, Jul 8, 2024 at 2:23 AM Karthik Nayak <karthik.188@gmail.com> wrote:

> The series was mostly inspired by a patch sent recently to 'include
> kh_foreach* macros in ForEachMacros' [1]. I was wondering why we don't
> run the formatting on CI and reduce some of the workload of reviewers.

As a big fan of automated formatting, I scanned through all of these. I did not spot anything problematic and had just a few minor comments. I'm not an expert on clang-format directives, nor on GitHub/GitLab CI, though. Anyway if you want it you can have a reviewed-by from me. :-)

(Comments stuck on individual patches)

Chris

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.