Re: [PATCH 5/8] clang-format: avoid braces on simple single-statement bodies

From: phillip.wood123@gmail.com <phillip.wood123@gmail.com>
Date: Jul 13, 2024, 13:58 UTC
Message-ID: <57402963-a95a-4bd8-9eb1-1764e0611bb5@gmail.com>
In-Reply-To: <CAOLa=ZSrVOBkziX+z3g1RqudiLp=SN4gW=OL5Ky++KukPF=QXA@mail.gmail.com>

On 13/07/2024 13:30, Karthik Nayak wrote:

> Phillip Wood <phillip.wood123@gmail.com> writes:

Show 9 quoted lines

>> I'm a bit confused - what does "allowed to fail" mean? We don't have any
>> automated requirements on the CI passing. We don't want to train
>> contributors to routinely ignore CI failures but if they don't get a
>> notification that this job failed how do they know to correct the
>> formatting?
>>
> 
> Well, it mostly means that the CI would show the style-check job as
> failed, but the overall pipeline would be successful.

Ah, I didn't know that was a possibility - do users still get emails about the failed job?

Show 5 quoted lines

> We want to ideally
> fail the pipeline too, but I'm being careful to not disrupt things
> suddenly and I think once we see what false positive rate is and once we
> fine tune this settings maybe over the next release or so, we can
> enforce this.

Starting gently to get some experience with the auto formatter sounds sensible. Thanks for working on this, I really hope that once we've got more experience with clang format we can figure out how to enable it unconditionally.

Best Wishes

Phillip