git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 02/12] ref-filter: use strbuf_split_str_omit_term()

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Feb 17, 2016, 17:39 UTC
Message-ID
<CAPig+cTrh4u7vgQRXOT0a-5St2a6TV4qfhOMCVSetbQD0kGTrQ@mail.gmail.com>
In-Reply-To
<CAOLa=ZQO065j5VfJabbV6jww5Z2f3jbaRQDfDcG9NY4x2txrFQ@mail.gmail.com>
On Wed, Feb 17, 2016 at 12:04 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
Show 16 quoted lines
> On Wed, Feb 17, 2016 at 2:39 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> My initial reaction was negative due to the heavy review burden this
>> series has demanded thus far, however, my mind was changing even as I
>> composed the above response. [...]
>>
>> So, I think I'm fine with it, if Karthik is game.
>
> Sounds good to me.
>
> I just read the conversation between Jeff, Junio and You about the whitespace
> counter-argument and I think its good to go ahead with v6 with Jeff's suggested
> change.
>
> Since he's already pushed the changes on top of my changes to:
>  git://github.com/peff/git.git jk/tweaked-ref-filter
> I'll just have a look and push that to the list as v6.

I reviewed the entire series again, including Peff's changes, so this entire series is:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>

Karthik, feel free to include my Reviewed-by: in all the patches (including Peff's) when you post v6.

Thanks.
Previous: Karthik NayakNext: Karthik Nayak
Message 18 of 32 in “ref-filter: use parsing functions”
  1. 00/12 ref-filter: use parsing functionsKarthik Nayak, Feb 16, 2016
  2. 01/12 strbuf: introduce strbuf_split_str_omit_term()Karthik Nayak, Feb 16, 2016
  3. 02/12 ref-filter: use strbuf_split_str_omit_term()Karthik Nayak, Feb 16, 2016
  4. Jeff KingFeb 16, 2016
  5. Jeff KingFeb 16, 2016
  6. Eric SunshineFeb 16, 2016
  7. Jeff KingFeb 16, 2016
  8. Eric SunshineFeb 16, 2016
  9. Jeff KingFeb 16, 2016
  10. Eric SunshineFeb 16, 2016
  11. Jeff KingFeb 16, 2016
  12. Junio C HamanoFeb 17, 2016
  13. Jeff KingFeb 17, 2016
  14. Junio C HamanoFeb 17, 2016
  15. Jeff KingFeb 17, 2016
  16. Junio C HamanoFeb 17, 2016
  17. Karthik NayakFeb 17, 2016
  18. Eric SunshineFeb 17, 2016
  19. Karthik NayakFeb 17, 2016
  20. Eric SunshineFeb 17, 2016
  21. Karthik NayakFeb 17, 2016
  22. Karthik NayakFeb 17, 2016
  23. 03/12 ref-filter: bump 'used_atom' and related code to the topKarthik Nayak, Feb 16, 2016
  24. 04/12 ref-filter: introduce struct used_atomKarthik Nayak, Feb 16, 2016
  25. 05/12 ref-filter: introduce parsing functions for each valid atomKarthik Nayak, Feb 16, 2016
  26. 06/12 ref-filter: introduce color_atom_parser()Karthik Nayak, Feb 16, 2016
  27. 07/12 ref-filter: introduce parse_align_position()Karthik Nayak, Feb 16, 2016
  28. 08/12 ref-filter: introduce align_atom_parser()Karthik Nayak, Feb 16, 2016
  29. 09/12 ref-filter: align: introduce long-form syntaxKarthik Nayak, Feb 16, 2016
  30. 10/12 ref-filter: introduce remote_ref_atom_parser()Karthik Nayak, Feb 16, 2016
  31. 11/12 ref-filter: introduce contents_atom_parser()Karthik Nayak, Feb 16, 2016
  32. 12/12 ref-filter: introduce objectname_atom_parser()Karthik Nayak, Feb 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.