From: Eric Sunshine Date: Wed, 17 Feb 2016 17:39:38 GMT Subject: Re: [PATCH v5 02/12] ref-filter: use strbuf_split_str_omit_term() Message-ID: In-Reply-To: On Wed, Feb 17, 2016 at 12:04 PM, Karthik Nayak wrote: > On Wed, Feb 17, 2016 at 2:39 AM, Eric Sunshine wrote: >> My initial reaction was negative due to the heavy review burden this >> series has demanded thus far, however, my mind was changing even as I >> composed the above response. [...] >> >> So, I think I'm fine with it, if Karthik is game. > > Sounds good to me. > > I just read the conversation between Jeff, Junio and You about the whitespace > counter-argument and I think its good to go ahead with v6 with Jeff's suggested > change. > > Since he's already pushed the changes on top of my changes to: > git://github.com/peff/git.git jk/tweaked-ref-filter > I'll just have a look and push that to the list as v6. I reviewed the entire series again, including Peff's changes, so this entire series is: Reviewed-by: Eric Sunshine Karthik, feel free to include my Reviewed-by: in all the patches (including Peff's) when you post v6. Thanks.