git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 02/12] ref-filter: use strbuf_split_str_omit_term()

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 17, 2016, 00:28 UTC
Message-ID
<xmqq37sskwo5.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160217002215.GA1187@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 14 quoted lines
> On Tue, Feb 16, 2016 at 04:12:08PM -0800, Junio C Hamano wrote:
>
>> > To be honest, though, I am now on the fence, considering the possible
>> > whitespace issue.
>> 
>> Certainly not having to see s[0]->buf over and over is a huge win ;-).
>> 
>> Is the "whitespace issue" a big deal?  Does it involve more than a
>> similar sibling to string_list_split() that trims the whitespace
>> around the delimiter (or allows a regexp as a delimiter "\s*,\s*")?
>
> I think that solution would work (and IMHO would actually be preferable
> to the split-then-trim that strbuf_split does). But it does mean writing
> new code.

True, but only when we decide to support trimming the whitespace, which can come later.

I do not even know if it is wise to accept %(align:position=left, width=4) when %(align:position=left,width=4) would do the job just fine.

Previous: Jeff KingNext: Jeff King
Message 14 of 32 in “ref-filter: use parsing functions”
  1. 00/12 ref-filter: use parsing functionsKarthik Nayak, Feb 16, 2016
  2. 01/12 strbuf: introduce strbuf_split_str_omit_term()Karthik Nayak, Feb 16, 2016
  3. 02/12 ref-filter: use strbuf_split_str_omit_term()Karthik Nayak, Feb 16, 2016
  4. Jeff KingFeb 16, 2016
  5. Jeff KingFeb 16, 2016
  6. Eric SunshineFeb 16, 2016
  7. Jeff KingFeb 16, 2016
  8. Eric SunshineFeb 16, 2016
  9. Jeff KingFeb 16, 2016
  10. Eric SunshineFeb 16, 2016
  11. Jeff KingFeb 16, 2016
  12. Junio C HamanoFeb 17, 2016
  13. Jeff KingFeb 17, 2016
  14. Junio C HamanoFeb 17, 2016
  15. Jeff KingFeb 17, 2016
  16. Junio C HamanoFeb 17, 2016
  17. Karthik NayakFeb 17, 2016
  18. Eric SunshineFeb 17, 2016
  19. Karthik NayakFeb 17, 2016
  20. Eric SunshineFeb 17, 2016
  21. Karthik NayakFeb 17, 2016
  22. Karthik NayakFeb 17, 2016
  23. 03/12 ref-filter: bump 'used_atom' and related code to the topKarthik Nayak, Feb 16, 2016
  24. 04/12 ref-filter: introduce struct used_atomKarthik Nayak, Feb 16, 2016
  25. 05/12 ref-filter: introduce parsing functions for each valid atomKarthik Nayak, Feb 16, 2016
  26. 06/12 ref-filter: introduce color_atom_parser()Karthik Nayak, Feb 16, 2016
  27. 07/12 ref-filter: introduce parse_align_position()Karthik Nayak, Feb 16, 2016
  28. 08/12 ref-filter: introduce align_atom_parser()Karthik Nayak, Feb 16, 2016
  29. 09/12 ref-filter: align: introduce long-form syntaxKarthik Nayak, Feb 16, 2016
  30. 10/12 ref-filter: introduce remote_ref_atom_parser()Karthik Nayak, Feb 16, 2016
  31. 11/12 ref-filter: introduce contents_atom_parser()Karthik Nayak, Feb 16, 2016
  32. 12/12 ref-filter: introduce objectname_atom_parser()Karthik Nayak, Feb 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.