Re: [PATCH 2/3] ls-tree: update usage info

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 3, 2018, 07:18 UTC
Message-ID: <CAPig+cTf3iUSuopwKj_8OC9qf3kpD9=_Aika+_Xb-_kt1TxgPQ@mail.gmail.com>
In-Reply-To: <20180703035802.24060-2-jyn514@gmail.com>

On Mon, Jul 2, 2018 at 11:58 PM Joshua Nelson <jyn514@gmail.com> wrote:

Show 7 quoted lines

> show [tree-ish] and [--] as optional
> ---
> diff --git builtin/ls-tree.c builtin/ls-tree.c
> @@ -26,7 +26,7 @@ static int chomp_prefix;
>  static const  char * const ls_tree_usage[] = {
> -       N_("git ls-tree [<options>] <tree-ish> [<path>...]"),
> +       N_("git ls-tree [<options>] [tree-ish] [--] [<path>...]"),

You lost the '<' and '>'. This should be typeset as:

    git ls-tree [<options>] [<tree-ish>] [--] [<path>...]

And, as Elijah noted, Documentation/git-ls-tree.txt needs an update.