Re: [PATCH 2/3] ls-tree: update usage info

From: Elijah Newren <newren@gmail.com>
Date: Jul 3, 2018, 07:14 UTC
Message-ID: <CABPp-BFLciH4H712LzwXyn22esRU6FN87SLbUqOJP3CKvx+DdA@mail.gmail.com>
In-Reply-To: <20180703035802.24060-2-jyn514@gmail.com>

Hi Joshua,

On Mon, Jul 2, 2018 at 8:58 PM, Joshua Nelson <jyn514@gmail.com> wrote:

> show [tree-ish] and [--] as optional

You're missing a Signed-off-by tag here.

Show 5 quoted lines

> ---
>  builtin/ls-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git builtin/ls-tree.c builtin/ls-tree.c

No corresponding update to Documentation/git-ls-tree.txt?

Show 14 quoted lines

> index 14102b052..c5649b09c 100644
> --- builtin/ls-tree.c
> +++ builtin/ls-tree.c
> @@ -26,7 +26,7 @@ static int chomp_prefix;
>  static const char *ls_tree_prefix;
>
>  static const  char * const ls_tree_usage[] = {
> -       N_("git ls-tree [<options>] <tree-ish> [<path>...]"),
> +       N_("git ls-tree [<options>] [tree-ish] [--] [<path>...]"),
>         NULL
>  };
>
> --
> 2.18.GIT