From: Eric Sunshine Date: Tue, 03 Jul 2018 07:18:27 GMT Subject: Re: [PATCH 2/3] ls-tree: update usage info Message-ID: In-Reply-To: <20180703035802.24060-2-jyn514@gmail.com> On Mon, Jul 2, 2018 at 11:58 PM Joshua Nelson wrote: > show [tree-ish] and [--] as optional > --- > diff --git builtin/ls-tree.c builtin/ls-tree.c > @@ -26,7 +26,7 @@ static int chomp_prefix; > static const char * const ls_tree_usage[] = { > - N_("git ls-tree [] [...]"), > + N_("git ls-tree [] [tree-ish] [--] [...]"), You lost the '<' and '>'. This should be typeset as: git ls-tree [] [] [--] [...] And, as Elijah noted, Documentation/git-ls-tree.txt needs an update.