Re: [PATCH] ls-tree: make <tree-ish> optional

From: Joshua Nelson <jyn514@gmail.com>
Date: Jul 4, 2018, 00:05 UTC
Message-ID: <368608dc-4351-541c-0236-9f5760ca5d97@gmail.com>
In-Reply-To: <20180703235337.31770-1-jyn514@gmail.com>

On 07/03/2018 07:53 PM, Joshua Nelson wrote:

Show 16 quoted lines

> diff --git a/t/t3104-ls-tree-optional-args.sh b/t/t3104-ls-tree-optional-args.sh
> new file mode 100755
> index 000000000..e9d8389bc
> --- /dev/null
> +++ b/t/t3104-ls-tree-optional-args.sh
> @@ -0,0 +1,63 @@
> +#!/bin/sh
> +
> +test_description='ls-tree test (optional args)
> +
> +This test runs git-ls-tree with ambiguous positional options.'
> +
> +# cat appends newlines after every file
> +test_expect_success 'show HEAD when given no args' '
> +	if [ "$(git ls-tree)" != "$(cat expected1 expected2)" ]; then false; fi
> +'

I forgot to take out the comment about cat; it's not actually true, I just happened to be using echo instead of printf when I wrote it.

Is it customary to send a new patch or second patch that builds on the first? If I specify a commit range to git-send-email it sends both, not just the latest.