git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] smart-http: document flush after "# service" line

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 3, 2018, 08:28 UTC
Message-ID
<CAPig+cT4NhhZNaYYXZL3dqvVn++KrNSL1bQRtdPt4RqfPexAnA@mail.gmail.com>
In-Reply-To
<20180303052708.GF27689@sigill.intra.peff.net>
On Sat, Mar 3, 2018 at 12:27 AM, Jeff King <peff@peff.net> wrote:
Show 5 quoted lines
> Subject: smart-http: document flush after "# service" line
>
> The http-protocol.txt spec fails to mention that a flush
> packet comes in the smart server response after sending any
> the "service" header.
"any the"?
Show 11 quoted lines
> Technically the client code is actually ready to receive an
> arbitrary number of headers here, but since we haven't
> introduced any other headers in the past decade (and the
> client would just throw them away), let's not mention it in
> the spec.
>
> This fixes both BNF and the example. While we're fixing the
> latter, let's also add the missing flush after the ref list.
>
> Reported-by: Dorian Taylor <dorian.taylor.lists@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>
Previous: Jeff KingNext: Jeff King
Message 11 of 13 in “bug in HTTP protocol spec”
  1. Dorian TaylorFeb 21, 2018
  2. Jeff KingFeb 21, 2018
  3. Dorian TaylorFeb 21, 2018
  4. Jonathan NiederFeb 22, 2018
  5. Dorian TaylorFeb 22, 2018
  6. Jeff KingFeb 22, 2018
  7. Dorian TaylorFeb 22, 2018
  8. Junio C HamanoFeb 22, 2018
  9. Dorian TaylorFeb 22, 2018
  10. smart-http: document flush after "# service" lineJeff King, Mar 3, 2018
  11. Eric SunshineMar 3, 2018
  12. Jeff KingMar 3, 2018
  13. Brandon WilliamsFeb 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.