Re: bug in HTTP protocol spec

From: Dorian Taylor <dorian.taylor.lists@gmail.com>
Date: Feb 22, 2018, 20:12 UTC
Message-ID: <01B07AA7-B2A4-4A81-B1F0-E2EC3D6BFBF9@gmail.com>
In-Reply-To: <xmqqbmggx063.fsf@gitster-ct.c.googlers.com>

Show 5 quoted lines

> On Feb 22, 2018, at 12:02 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> I saw somewhere "Apple-Mail" and a phrase "repaste".  So perhaps
> copy&paste on the client is involved in the whitespace damage (of
> course the original could be broken, but I somehow doubt it).

https://doriantaylor.com/file/well-ill-be-damned.png

Show 7 quoted lines

> For what it's worth, I am slightly negative on this addition.  It
> makes it inconsistent if we only mention it about _this_ flush and
> not any other flush.  It even gets in the way of learning the
> protocol by new people reading it, by giving an impression that
> somehow LF is outside and in between packet line.
> 
> Thanks.

This patch exists because I was asked to write it. I don’t know squat about this protocol other than the fact that I followed the spec and it didn’t work. I traced a known-good protocol endpoint and found it contained content that didn’t agree with the spec. I then obliged the request to submit a patch with *what I knew to be true* about the sample that actually worked. I then followed the recommendations *advertised on GitHub* for submitting the patch.

You’re welcome.

-- Dorian Taylor Make things. Make sense. https://doriantaylor.com