From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sat, 03 Mar 2018 08:28:47 GMT
Subject: Re: [PATCH] smart-http: document flush after "# service" line
Message-ID: <CAPig+cT4NhhZNaYYXZL3dqvVn++KrNSL1bQRtdPt4RqfPexAnA@mail.gmail.com>
In-Reply-To: <20180303052708.GF27689@sigill.intra.peff.net>

On Sat, Mar 3, 2018 at 12:27 AM, Jeff King <peff@peff.net> wrote:
> Subject: smart-http: document flush after "# service" line
>
> The http-protocol.txt spec fails to mention that a flush
> packet comes in the smart server response after sending any
> the "service" header.

"any the"?

> Technically the client code is actually ready to receive an
> arbitrary number of headers here, but since we haven't
> introduced any other headers in the past decade (and the
> client would just throw them away), let's not mention it in
> the spec.
>
> This fixes both BNF and the example. While we're fixing the
> latter, let's also add the missing flush after the ref list.
>
> Reported-by: Dorian Taylor <dorian.taylor.lists@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>