Re: bug in HTTP protocol spec

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 22, 2018, 05:37 UTC
Message-ID: <20180222053722.GB133592@aiede.svl.corp.google.com>
In-Reply-To: <89E9DF80-F811-4F7A-AA35-0F52F1180BAF@gmail.com>

(+cc: bmwill@, who is working on protocol v2) Hi,

Dorian Taylor wrote:

> On Feb 21, 2018, at 2:15 PM, Jeff King <peff@peff.net> wrote:

>> Thanks, I agree the document is buggy. Do you want to submit a patch?
>
> Will this do?

Thanks for writing it.

Do you mind if we forge your sign-off? (See Documentation/SubmittingPatches item '(5) Certify your work' for details about what this means.)

> Note I am not sure what the story is behind that `version 1`
> element, whether it's supposed to go before or after the null packet
> or if there should be another null packet or what. Perhaps somebody
> more fluent with the smart protocol can advise.

I believe the 'version 1' goes after the flush-packet.

Thanks, Jonathan