git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] Add test for commit --dry-run --short.

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Sep 2, 2018, 02:22 UTC
Message-ID
<CAPig+cSnFE9G+09LucqTQXM7nKOXPkJ45CR-hkaA+5y9JdaNHw@mail.gmail.com>
In-Reply-To
<CAPig+cTzBTA4hSkM9ZtRVARZEwXMv1o9GnPMrBGimt-g=ExmHw@mail.gmail.com>
On Sat, Sep 1, 2018 at 10:18 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 5 quoted lines
> On Sat, Sep 1, 2018 at 7:53 PM Stephen P. Smith <ischis2@cox.net> wrote:
> > The test demonstrates that the setting of the commitable flag is
> > broken.
>
> s/commitable/committable/

Looking at patch 3/3, I see that this misspelling exists in the code itself, so I guess my recommended spelling correction isn't needed. It might make sense, though, to quote this word in the commit message to make it more clear that that is the literal spelling in the code. That is:

   ...demonstrates that the setting of the 'commitable' flag...
(Not itself worth a re-roll.)
Previous: Eric SunshineNext: Stephen & Linda Smith
Message 5 of 7 in “wt-status.c: commitable flag”
  1. 0/3 wt-status.c: commitable flagStephen P. Smith, Sep 1, 2018
  2. 1/3 wt-status.c: Move has_unmerged earlier in the file.Stephen P. Smith, Sep 1, 2018
  3. 2/3 Add test for commit --dry-run --short.Stephen P. Smith, Sep 1, 2018
  4. Eric SunshineSep 2, 2018
  5. Eric SunshineSep 2, 2018
  6. Stephen & Linda SmithSep 2, 2018
  7. 3/3 wt-status.c: Set the commitable flag in the collect phase.Stephen P. Smith, Sep 1, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.