From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sun, 02 Sep 2018 02:22:42 GMT
Subject: Re: [PATCH v2 2/3] Add test for commit --dry-run --short.
Message-ID: <CAPig+cSnFE9G+09LucqTQXM7nKOXPkJ45CR-hkaA+5y9JdaNHw@mail.gmail.com>
In-Reply-To: <CAPig+cTzBTA4hSkM9ZtRVARZEwXMv1o9GnPMrBGimt-g=ExmHw@mail.gmail.com>

On Sat, Sep 1, 2018 at 10:18 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sat, Sep 1, 2018 at 7:53 PM Stephen P. Smith <ischis2@cox.net> wrote:
> > The test demonstrates that the setting of the commitable flag is
> > broken.
>
> s/commitable/committable/

Looking at patch 3/3, I see that this misspelling exists in the code
itself, so I guess my recommended spelling correction isn't needed. It
might make sense, though, to quote this word in the commit message to
make it more clear that that is the literal spelling in the code. That
is:

   ...demonstrates that the setting of the 'commitable' flag...

(Not itself worth a re-roll.)