Re: [PATCH v2 2/3] Add test for commit --dry-run --short.

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 2, 2018, 02:18 UTC
Message-ID: <CAPig+cTzBTA4hSkM9ZtRVARZEwXMv1o9GnPMrBGimt-g=ExmHw@mail.gmail.com>
In-Reply-To: <20180901235256.4260-3-ischis2@cox.net>

On Sat, Sep 1, 2018 at 7:53 PM Stephen P. Smith <ischis2@cox.net> wrote:

> Add test for commit --dry-run --short.

The first line of a commit message typically mentions the area or module being touched. It's also customary not to capitalize the first word and to omit the final period. So, for instance:

    t7501: add test of "--dry-run --short" setting 'committable' flag

Show 5 quoted lines

> Add test for commit with --dry-run --short for a new file of zero
> length.
>
> The test demonstrates that the setting of the commitable flag is
> broken.

s/commitable/committable/

Show 7 quoted lines

> Signed-off-by: Stephen P. Smith <ischis2@cox.net>
> ---
> diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
> @@ -682,4 +682,12 @@ test_expect_success '--dry-run with conflicts fixed from a merge' '
> +test_expect_failure '--dry-run --short' '
> +       # setup two branches with conflicting information
> +       # in the same file, resolve the conflict

What is this comment all about? It doesn't seem to have any relation to what the test itself is actually doing. (I see that it was copied from an earlier test in this script, but that doesn't help me understand what it is trying to say.)

> +       >test-file &&
> +       git add test-file &&
> +       git commit --dry-run --short
> +'